Skip to content

FIX: Analytics errors on consoles by reverting changes from #1991 #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2024
Merged

FIX: Analytics errors on consoles by reverting changes from #1991 #2024

merged 3 commits into from
Oct 10, 2024

Conversation

Pauliusd01
Copy link
Collaborator

@Pauliusd01 Pauliusd01 commented Oct 3, 2024 •
edited
Loading

Description

This PR reverts changes from here: #1991
As they've caused analytics errors on 22.3. For more context please check the latest #devs-input thread on slack

Testing done

Will check building the Xbox Platform on a VM as well as Input System basics

To Reviewers

Please try to build and run projects on your platforms on the 22.3 and U6 Editors.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

lyndon-unity
lyndon-unity approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Paulius - this looks as expected for the revert + good to see you added the change log.

lewish-unity
lewish-unity approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@lewish-unity lewish-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks correct.

I tested locally and had no issues with 2022.3.49f1.

cristian-murarescu
cristian-murarescu approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@cristian-murarescu cristian-murarescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on PS4, PS5 & Switch, all good.

@Pauliusd01 Pauliusd01 removed the request for review from MahumKhan October 10, 2024 06:00
ekcoh
ekcoh approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine to me. I guess we just risk not logging certain analytics now (which was the reason for my previous change), might need QA across version ranges then to see all analytics pass through with this way of evaluating symbols?

@Pauliusd01
Copy link
Collaborator Author

Pauliusd01 commented Oct 10, 2024 •
edited
Loading

Changes looks fine to me. I guess we just risk not logging certain analytics now (which was the reason for my previous change), might need QA across version ranges then to see all analytics pass through with this way of evaluating symbols?

I've tried the debugger in U6 and I'm still seeing input actions asset related logs, just like last time: context menu actions, interaction/processor adding and file saving. (On 22.3 the debugger is not compatible so I cannot check there)

@Pauliusd01 Pauliusd01 merged commit b3549ac into develop Oct 10, 2024
2 of 76 checks passed
@Pauliusd01 Pauliusd01 deleted the isxb-1107-revert-anylitics-changes-from-1991 branch October 10, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekcoh ekcoh ekcoh approved these changes

@lyndon-unity lyndon-unity lyndon-unity approved these changes

@lewish-unity lewish-unity lewish-unity approved these changes

@cristian-murarescu cristian-murarescu cristian-murarescu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Pauliusd01 @ekcoh @lyndon-unity @lewish-unity @cristian-murarescu